This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
tmp fix: broken icon on linux (deb) #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@polarker thanks, I missed the fact that my fork was just a bit behind so I updated my branch 🙄 |
0xjac
added a commit
to 0xjac/alephium-wallet
that referenced
this pull request
Nov 5, 2021
Electron should use the executable icon as the default application window. However this seems broken on Linux. This might be related to alephium#41 This sets the alephium icon for the application to be displayed by the wm on the window decoration, on windows switchers, etc.
polarker
pushed a commit
that referenced
this pull request
Nov 9, 2021
Electron should use the executable icon as the default application window. However this seems broken on Linux. This might be related to #41 This sets the alephium icon for the application to be displayed by the wm on the window decoration, on windows switchers, etc.
LeeAlephium
pushed a commit
that referenced
this pull request
May 24, 2022
tmp fix: broken icon on linux (deb)
LeeAlephium
pushed a commit
that referenced
this pull request
May 24, 2022
Electron should use the executable icon as the default application window. However this seems broken on Linux. This might be related to #41 This sets the alephium icon for the application to be displayed by the wm on the window decoration, on windows switchers, etc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The icon is package incorrectly for linux (deb). This is due to a bug in
app-builderwhich is a dependency (wrapped as a npm module inapp-builder-bin) of electron-builder, the tool used for packaging.There is a fix for it, but it hasn't been merged yet. And once it is the following must happened:
app-buildermust be released with the fix, together with a new version of the js wrapper (app-builder-bin).electron-buildermust update its dependencies to include the new version ofapp-builder-bin.electron-builderwith the updated dependencies must be released.electron-builderdev dependency ofalephium-walletmust be updated.alephium-walletcan be released with the icon.While I'm confident that you can do the last two points quite quickly (providing no breaking changes from
electron-builder), all the former points may take some times and are outside this project's control. It's likely that this won't happen before the mainnet release. Hence I'm submitting this quick fix to manually set the icon size to512and package the icon correctly for the big day.If you would like to avoid hacks and temporary fixes like this one, feel free to close the PR 😉
Changes
This PR adds an
afterPackhook which after gathering all the files for adebarchives, remaps all icons with a size of0to512.Things to note:
0) size will not be affected.0size will be set to512.0and an actual size other than512will be packaged incorrectly.app-builderis fixed, the correct size of512should be detected and the hook should not have any effect. It can then be removed. (If it remains, it should have no effects, besides wasting some CPU cycles.)